Always use summary events for monitor info #82376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elastic#81942 With synthetics we no longer are guaranteed to have the URL or other monitor info fields in every single event. This PR patches the monitor status API to only query summary fields for this info. As an added benefit, this is a bit more consistent as well because we tend to only show data from completed, not partial checks, in most places. This also removes the status check parameter from this API, which otherwise would need to be refactored. Checking the codebase it appears unused.
andrewvc
added
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
andrewvc
added
bug
shahzad31
approved these changes
Nov 2, 2020
| @@ -46,7 +47,6 @@ export const getLatestMonitor: UMElasticsearchQueryFn<GetLatestMonitorParams, Pi | |||
| }, | |||
| }, | |||
| }, | |||
| ...(status ? [{ term: { 'monitor.status': status } }] : []), | |||
There was a problem hiding this comment.
You will also need to remove status from the function receiving params
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Nov 3, 2020
* Always use summary events for monitor info Fixes elastic#81942 With synthetics we no longer are guaranteed to have the URL or other monitor info fields in every single event. This PR patches the monitor status API to only query summary fields for this info. As an added benefit, this is a bit more consistent as well because we tend to only show data from completed, not partial checks, in most places. This also removes the status check parameter from this API, which otherwise would need to be refactored. Checking the codebase it appears unused. * Remove unneeded params
andrewvc
added a commit
to andrewvc/kibana
that referenced
this pull request
Nov 3, 2020
* Always use summary events for monitor info Fixes elastic#81942 With synthetics we no longer are guaranteed to have the URL or other monitor info fields in every single event. This PR patches the monitor status API to only query summary fields for this info. As an added benefit, this is a bit more consistent as well because we tend to only show data from completed, not partial checks, in most places. This also removes the status check parameter from this API, which otherwise would need to be refactored. Checking the codebase it appears unused. * Remove unneeded params
andrewvc
added a commit
that referenced
this pull request
Nov 3, 2020
* Always use summary events for monitor info Fixes #81942 With synthetics we no longer are guaranteed to have the URL or other monitor info fields in every single event. This PR patches the monitor status API to only query summary fields for this info. As an added benefit, this is a bit more consistent as well because we tend to only show data from completed, not partial checks, in most places. This also removes the status check parameter from this API, which otherwise would need to be refactored. Checking the codebase it appears unused. * Remove unneeded params
andrewvc
added a commit
that referenced
this pull request
Nov 3, 2020
* Always use summary events for monitor info Fixes #81942 With synthetics we no longer are guaranteed to have the URL or other monitor info fields in every single event. This PR patches the monitor status API to only query summary fields for this info. As an added benefit, this is a bit more consistent as well because we tend to only show data from completed, not partial checks, in most places. This also removes the status check parameter from this API, which otherwise would need to be refactored. Checking the codebase it appears unused. * Remove unneeded params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #81942
With synthetics we no longer are guaranteed to have the URL or other monitor info fields in every single event. This PR patches the monitor status API to only query summary fields for this info.
As an added benefit, this is a bit more consistent as well because we tend to only show data from completed, not partial checks, in most places.
This also removes the status check parameter from this API, which otherwise would need to be refactored. Checking the codebase it appears unused.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
For maintainers