[Lens] Add functional test for wrapping labels #82453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Lens
v7.11.0
v8.0.0
release_note:skip
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
approved these changes
Nov 4, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Nov 4, 2020
* add functional test for wrapping labels * fix unused import
flash1293
added a commit
that referenced
this pull request
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #72585
This adds a functional test to make sure the "remove dimension" button stays clickable even if the labels is really long.
To test the breaking case, remove this line:
kibana/x-pack/plugins/lens/public/editor_frame_service/editor_frame/config_panel/layer_panel.scss
Line 53 in 2de2c70
and run the smokescreen test suite.