Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Fix apm e2e runner script commands #82798

Merged
merged 4 commits into from
Nov 6, 2020

Conversation

ogupte
Copy link
Contributor

@ogupte ogupte commented Nov 6, 2020

Fixes apm e2e runner script by updating the yarn commands to match the script names defined in the package.json

This fixes this error when running x-pack/plugins/apm/e2e/run-e2e.sh:

Waiting for Kibana to start...
Note: you need to start Kibana manually. Find the instructions at the top.
error Command "wait-on" not found.
:white_check_mark: Setup completed successfully. Running tests...
yarn run v1.22.4
error Command "cypress" not found.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
If you want to run the test interactively, run:
cd . && yarn cypress open --config pageLoadTimeout=100000,watchForFileChanges=true
:warning:  Running tests failed.

@ogupte ogupte added release_note:skip Skip the PR/issue when compiling release notes v7.11.0 labels Nov 6, 2020
@ogupte ogupte requested a review from a team as a code owner November 6, 2020 01:11
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Nov 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte ogupte requested a review from mistic November 6, 2020 01:16
x-pack/plugins/apm/e2e/yarn.lock Outdated Show resolved Hide resolved
@sorenlouv
Copy link
Member

sorenlouv commented Nov 6, 2020

I think you should delete the local package.json file as well.

@ogupte
Copy link
Contributor Author

ogupte commented Nov 6, 2020

jenkins run the e2e

@smith smith requested a review from mistic November 6, 2020 14:13
@mistic
Copy link
Member

mistic commented Nov 6, 2020

@ogupte the build for apm is failing probably due to your last changes removing the local package.json. We can have it there for now to run the npm scripts (we are doing it on other places).

Copy link
Member

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

distributable file count

id before after diff
default 42729 42728 -1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit fb9d395 into elastic:master Nov 6, 2020
ogupte added a commit to ogupte/kibana that referenced this pull request Nov 6, 2020
* Fixes apm e2e runner script by updating the yarn commands to match the
script names defined in the package.json

* removes the yarn install step for cypress dependencies, since it's no
longer necessary.

* Removed apm/e2e/package.json

* simplified paths for binary dependencies
ogupte added a commit that referenced this pull request Nov 6, 2020
* Fixes apm e2e runner script by updating the yarn commands to match the
script names defined in the package.json

* removes the yarn install step for cypress dependencies, since it's no
longer necessary.

* Removed apm/e2e/package.json

* simplified paths for binary dependencies
gmmorris added a commit to gmmorris/kibana that referenced this pull request Nov 9, 2020
* master: (68 commits)
  [Fleet] Make stream id unique in agent policy (elastic#82447)
  skip flaky suite (elastic#82915)
  skip flaky suite (elastic#75794)
  Copy `dateAsStringRt` to observability plugin (elastic#82839)
  [Maps] rename connected_components/map folder to mb_map (elastic#82897)
  [Security Solution] Fix EventsViewer DnD cypress tests (elastic#82619)
  [Security Solution] Adds logging and performance fan out API for threat/Indicator matching (elastic#82546)
  Implemented Alerting health status pusher by using task manager and status pooler for Kibana status plugins 'kibanahost/api/status' (elastic#79056)
  [APM] Adds new configuration 'xpack.apm.maxServiceEnvironments' (elastic#82090)
  Move single use function in line (elastic#82885)
  [ML] Add unsigned_long support to data frame analytics and anomaly detection (elastic#82636)
  Add flot_chart dependency from shared_deps to Shareable Runtime (elastic#81649)
  [Security Solution][Detections] - Auto refresh all rules/monitoring tables (elastic#82062)
  [APM] Fix apm e2e runner script commands (elastic#82798)
  [Ingest Manager] Move cache functions to from registry to archive (elastic#82871)
  Update webpack-dev-server and webpack-cli (elastic#82844)
  [Uptime] Migrate to new es client (elastic#82003)
  Move parseAndVerify* functions to validation.ts (elastic#82845)
  Remove yeoman & yo (elastic#82825)
  [Canvas] Fix elements not being updated properly when filter is changed on workpad (elastic#81863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants