Remove redundant call to _authenticate API after access token is created.
#82980
Conversation
azasypkin
added
Team:Security
| @@ -4,6 +4,9 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import { AuthenticatedUser } from '../../common/model'; | |||
|
|
|||
| export type Authentication = Omit<AuthenticatedUser, 'authentication_provider'>; | |||
There was a problem hiding this comment.
note: not super happy about the name of this type, but don't have any other ideas what the type name of authentication response field could be ....
There was a problem hiding this comment.
For reference, we discussed the naming offline and decided to name this field AuthenticationInfo.
While being short, Authentication is slightly meaningless and could mean many things to different people.
According to the ES docs the authentication field represents:
User information such as their username, the roles that are assigned to the user, any assigned metadata, and information about the realms that authenticated and authorized the user
So renaming this type to AuthenticationInfo makes that a bit clearer.
|
Pinging @elastic/kibana-security (Team:Security) |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…eated. (elastic#82980) # Conflicts: # .github/CODEOWNERS # x-pack/plugins/security/server/authentication/providers/saml.test.ts # x-pack/plugins/security/server/authentication/providers/saml.ts
|
7.x/7.11.0: 660f712 |
Since elastic/elasticsearch#59685 is resolved now (7.11.0+) we can proceed and remove redundant
_authenticatecalls after we create any kind of access tokens (Token/SAML/OIDC/Kerberos/PKI) that would improve login performance and make code simpler overall.Fixes: #80952