Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workplace Search] Migrate SourcesLogic from ent-search #83544

Merged
merged 5 commits into from
Nov 17, 2020
Merged

[Workplace Search] Migrate SourcesLogic from ent-search #83544

merged 5 commits into from
Nov 17, 2020

Commits on Nov 17, 2020

  1. Copy and paste sources logic 

    This is simply a copy & paste of the sources_logic file from ent-search. The only changes were adding the comment at the top and changing how lodash imports, per linting requirements
    @scottybollinger
    scottybollinger committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    e6e639b View commit details
    Browse the repository at this point in the history

  2. Add types 

    The “I” prefix has been removed, per agreed-upon standard
    @scottybollinger
    scottybollinger committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    e46d40c View commit details
    Browse the repository at this point in the history

  3. Add type declaration to staticSourceData 

    Yay TypeScript  🙄
    @scottybollinger
    scottybollinger committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    27dd373 View commit details
    Browse the repository at this point in the history

  4. Update route path 

    For all other routes, we use the account/org syntax. For this one, I missed it and forgot to add ‘account’ for the route path. This fixes it
    @scottybollinger
    scottybollinger committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    1eee0c7 View commit details
    Browse the repository at this point in the history

  5. Update SourcesLogic to work with Kibana 

    - Remove routes/http in favor of HttpLogic
- Remove local flash messages in favor of global messages
- Update paths to imports
- Remove "I"s from interface names
- Varions type fixes
    @scottybollinger
    scottybollinger committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    7c17f35 View commit details
    Browse the repository at this point in the history