[ML] Persisted URL state for Data Frame Analytics Exploration page #84499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:enhancement
:ml
v8.0.0
Feature:Data Frame Analytics
|
Pinging @elastic/ml-ui (:ml) |
7 tasks
walterra
approved these changes
Nov 30, 2020
| @@ -8,6 +8,8 @@ import { RefreshInterval, TimeRange } from '../../../../../src/plugins/data/comm | |||
| import { JobId } from './anomaly_detection_jobs/job'; | |||
| import { ML_PAGES } from '../constants/ml_url_generator'; | |||
| import { DataFrameAnalysisConfigType } from './data_frame_analytics'; | |||
| import { SearchQueryLanguage } from '../constants/search'; | |||
There was a problem hiding this comment.
Nit: Could be import type ..., could help keeping the page load bundle size down since I think we expose the url generator.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
darnautov
added a commit
that referenced
this pull request
Nov 30, 2020
…84499) (#84563) * [ML] store query string in the URL state * [ML] query state for the config step * [ML] pagination in the URL state * [ML] persisted URL state for outlier results exploration * [ML] update URL generator * [ML] do not update the url state when query string hasn't been changed * [ML] store expandable panels state in the URL * [ML] fix TS issue * [ML] fix TS issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #83033
Adds the following parameters of the Data Frama Analytics Exploration page to the URL state:
Checklist