[Fleet] Support editing bool variable in agent policy #85070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
neptunian
reviewed
Dec 9, 2020
...ctions/agent_policy/create_package_policy_page/components/package_policy_input_var_field.tsx
Outdated
Show resolved
Hide resolved
neptunian
reviewed
Dec 9, 2020
...ctions/agent_policy/create_package_policy_page/components/package_policy_input_var_field.tsx
Outdated
Show resolved
Hide resolved
|
Testing with |
neptunian
approved these changes
Dec 9, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
Distributable file count
History
To update your PR or re-run it, just comment with: |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Dec 9, 2020
nchaulet
added a commit
that referenced
this pull request
Dec 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #84699
This PR allow to edit
boolvariables in the an agent policy, previously we were displaying a text field for boolean variable that is not the best experience for our user.Note: currently the variables are not validated server side, and this PR do not had server side validation (TODO find the issue where it's tracked)
Display an
EuiSwitchif the variable type is boolean, remove the Optional Label as it does not make sense hereUI Change
How to test this?
You can add and edit the system integration, the System process metrics contains a few bool variables