Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Alerting UI][License] Disable alert types in UI when the license doesn't support it. #85494

Closed
wants to merge 4 commits into from
Closed

[Alerting UI][License] Disable alert types in UI when the license doesn't support it. #85494

wants to merge 4 commits into from

Conversation

YulNaumenko
Copy link
Contributor

Resolve #85282

YulNaumenko and others added 4 commits December 8, 2020 12:41
@YulNaumenko
[Alerts][License] Define minimum license required for each alert type (…
b20db60 
…elastic#84997)

* Define minimum license required for each alert type

* fixed typechecks

* fixed tests

* fixed tests

* fixed due to comments

* fixed due to comments

* removed file

* removed casting to LicenseType
@YulNaumenko
Merge remote-tracking branch upstream/master
6e6a088
@YulNaumenko
Merge remote-tracking branch upstream/master
09d437f
@YulNaumenko
[Alerting UI][License] Disable alert types in UI when the license doe…
d03cf87 
…sn't support it.
@YulNaumenko YulNaumenko added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 labels Dec 9, 2020
@YulNaumenko YulNaumenko self-assigned this Dec 9, 2020
@YulNaumenko YulNaumenko closed this Dec 9, 2020
@kibanamachine
Copy link
Contributor

kibanamachine commented Dec 10, 2020 •
edited
Loading

💔 Build Failed

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 297 298 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB +1008.0B

Distributable file count

id before after diff
default 46986 47746 +760

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 48.8KB 49.0KB +124.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@YulNaumenko YulNaumenko

Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerting UI][License] Disable alert types in UI when the license doesn't support it.
2 participants
@YulNaumenko @kibanamachine