Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify number pattern to color format #8581

Closed
wants to merge 2 commits into from

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented Oct 6, 2016

Closes #8565

Note: this should NOT be backported before 5.0 release.

@thomasneirynck
Copy link
Contributor Author

let's hold off on this until we decided on a course of action for #8583.

@kobelb kobelb removed their assignment Oct 7, 2016
@epixa epixa added v5.1.0 and removed v5.0.0 labels Oct 7, 2016
@epixa
Copy link
Contributor

epixa commented Oct 7, 2016

I know you're holding off on this for now, but in general: any feature/enhancement should be targeting 5.1.0 at the soonest. The 5.0 branch is for bug fixes and such only.

@epixa epixa changed the title Add ability to specify number pattern to color format Ability to specify number pattern to color format Oct 8, 2016
@epixa epixa added blocked and removed review labels Oct 8, 2016
@tbragin tbragin added :Management Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Nov 12, 2016
@thomasneirynck
Copy link
Contributor Author

this isn't going anywhere, so let's close this.

This should better be addressed by also removing the API dependency on numeral.js (#8583)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Visualizations Generic visualization features (in case no more specific feature label is available)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants