Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] Remove grunt docker:docs task #85848

Merged
merged 4 commits into from
Dec 21, 2020
Merged

Conversation

jbudz
Copy link
Member

@jbudz jbudz commented Dec 14, 2020

Part of a larger effort to remove our grunt depedencies, #85341.

Part of a larger effort to remote our grunt depdencies, elastic#85341.
@jbudz jbudz added Team:Operations Team label for Operations Team v7.12.0 v8.0.0 labels Dec 14, 2020
@jbudz
Copy link
Member Author

jbudz commented Dec 14, 2020

while testing I noticed this was missing a docker dependency. It's been unmaintained, we get docs builds from elasticsearch-ci, and there's a cli at node scripts/docs for local usage. No reason to keep it around, I'm going to remove all of it.

@jbudz jbudz changed the title [build] Replace grunt docker:docs with script [build] Remove grunt docker:docs Dec 14, 2020
@jbudz jbudz changed the title [build] Remove grunt docker:docs [build] Remove grunt docker:docs task Dec 14, 2020
@jbudz jbudz marked this pull request as ready for review December 14, 2020 21:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@jbudz jbudz added the release_note:skip Skip the PR/issue when compiling release notes label Dec 14, 2020
@jbudz
Copy link
Member Author

jbudz commented Dec 16, 2020

@elasticmachine merge upstream

@tylersmalley
Copy link
Contributor

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Distributable file count

id before after diff
default 47143 47903 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jbudz jbudz merged commit 26b784b into elastic:master Dec 21, 2020
@jbudz jbudz deleted the grunt/rm-docker-docs branch December 21, 2020 21:18
jbudz added a commit that referenced this pull request Dec 21, 2020
@jbudz
Copy link
Member Author

jbudz commented Dec 21, 2020

7.x/7.12: d9bcdd0

gmmorris added a commit to gmmorris/kibana that referenced this pull request Dec 22, 2020
* master: (36 commits)
  update apm index pattern (elastic#86739)
  [Visualizations] Remove vis_default_editor - visualize plugins cyclic dependencies (elastic#85422)
  [ML] Fix alignment of values in data frame analytics results view badges (elastic#86621)
  [Visualizations] Remove charts - editor plugins cyclic dependencies (elastic#84887)
  fixing blank page (elastic#86640)
  Update dependency vega to ^5.17.1 (elastic#86715)
  [Monitoring] Convert Kibana-related server files that read from _source to typescript (elastic#86364)
  Uses @elastic/elasticsearch-canary (elastic#86398)
  [CI] Removes script previously used for Karma (elastic#86412)
  [build] Remove grunt checkPlugins task (elastic#85852)
  [build] Remove grunt docker:docs task (elastic#85848)
  [ML] Add doc link for classification AUC ROC evaluation (elastic#86660)
  [ML] Edits saved object synchronization message (elastic#86664)
  Uses the new es client in canvas usage collector's fetch methods (elastic#86668)
  [ML] Support legacy watcher URL (elastic#86661)
  [ML] Fix Single Metric Viewer y domain extending beyond the visible focus area (elastic#86655)
  Migrates search telemetry usage collector es client from legacy to new (elastic#86597)
  [Alerting] Encourage type safe usage of Alerting (elastic#86623)
  Migrates kql_telemetry usage collector es client (elastic#86585)
  [ML] Fix time range adjustment for the swim lane causing the infinite loop update (elastic#86461)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants