[Presentation Team] Migrate to Typescript Project References #86019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
added
Feature:Dashboard
clintandrewhall
changed the title
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@elasticmachine merge upstream |
|
@clintandrewhall are there any blockers to merge the PR? |
mshustov
approved these changes
Jan 29, 2021
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
tsullivan
reviewed
Jan 29, 2021
| { "path": "./src/plugins/data/tsconfig.json" }, | ||
| { "path": "./src/plugins/dev_tools/tsconfig.json" }, | ||
| { "path": "./src/plugins/discover/tsconfig.json" }, | ||
| { "path": "./src/plugins/embeddable/tsconfig.json" }, | ||
| { "path": "./src/plugins/es_ui_shared/tsconfig.json" }, | ||
| { "path": "./src/plugins/expressions/tsconfig.json" }, | ||
| { "path": "./src/plugins/home/tsconfig.json" }, | ||
| { "path": "./src/plugins/dashboard/tsconfig.json" }, | ||
| { "path": "./src/plugins/dev_tools/tsconfig.json" }, |
There was a problem hiding this comment.
woah - nice job spotting a dup!
tsullivan
approved these changes
Jan 29, 2021
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
clintandrewhall
added a commit
to clintandrewhall/kibana
that referenced
this pull request
Jan 31, 2021
…#86019) Co-authored-by: Kibana Machine <[email protected]>
clintandrewhall
added a commit
that referenced
this pull request
Jan 31, 2021
…86019) (#89824) Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applies to #80508
This is a draft PR to set up Typescript projects for:
canvasinput_control_vispresentation_utilreporting