Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v31.0.0 #86689

Merged
merged 4 commits into from
Dec 22, 2020
Merged

Upgrade EUI to v31.0.0 #86689

merged 4 commits into from
Dec 22, 2020

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Dec 21, 2020 •
edited
Loading

Summary

[email protected] ⏩ [email protected]

  • Breaking changes have no impact on Kibana
  • Snapshot updates are due to className changes

31.0.0

  • Added collapsble behavior to EuiResizableContainer panels (#3978)
  • Updated EuiResizablePanel to use EuiPanel (#3978)
  • Changed showTimeSelect prop to true when showTimeSelectOnly prop is set to true. (#4372)
  • Updated EuiSuperSelect recently used list to render as <ol> and <li> elements (#4370)

Bug fixes

  • Fixed EuiSuggest popover opening when an empty array is passed into the suggestions prop (#4349)

Breaking changes

  • Removed size prop from EuiResizableButton (#3978)
  • Upgraded to TypeScript v4.0 (#4296)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Dec 21, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 8.5MB 8.5MB -172.0B

Distributable file count

id before after diff
default 47143 48019 +876
Unknown metric groups

@kbn/ui-shared-deps asset size

id before after diff
css 667.1KB 673.9KB +6.8KB
[email protected] 2.5MB 2.4MB -27.7KB
total -20.9KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thompsongl thompsongl marked this pull request as ready for review December 22, 2020 03:20
@thompsongl thompsongl requested review from a team as code owners December 22, 2020 03:20
@thompsongl thompsongl requested a review from a team December 22, 2020 03:20
@thompsongl thompsongl added the EUI label Dec 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-design (EUI)

patrykkopycinski
patrykkopycinski approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIEM/Endpoint app LGTM

jportner
jportner approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@jportner jportner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only, Security changes LGTM!

(reset session page snapshot -- euiPage div has an additional CSS class, euiPage--paddingMedium)

ThomThomson
ThomThomson approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team changes LGTM.

@thompsongl thompsongl merged commit c0d6bd9 into elastic:master Dec 22, 2020
@thompsongl thompsongl mentioned this pull request Dec 22, 2020
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Dec 22, 2020
@thompsongl
Upgrade EUI to v31.0.0 (elastic#86689)
0549993 
* eui to 31.0.0

* snapshot updates

* remove obsolete snapshot
thompsongl added a commit that referenced this pull request Dec 22, 2020
@thompsongl
Upgrade EUI to v31.0.0 (#86689) (#86824)
fffbe4d 
* eui to 31.0.0

* snapshot updates

* remove obsolete snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisronline chrisronline chrisronline approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@jportner jportner jportner approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@thompsongl @kibanamachine @elasticmachine @chrisronline @chandlerprall @patrykkopycinski @jportner @ThomThomson