Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Visualizations] Remove charts - editor plugins cyclic dependencies (#84887) #86730

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

stratoula
Copy link
Contributor

Backports the following commits to 7.x:

…lastic#84887)

* Remove charts - editor cyclic dependencies

* Move translations from the charts plugin to the editor plugin

* Remove the dependency from the script as it is gone

* Fix types

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
charts 76 67 -9
visDefaultEditor 115 125 +10
total +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.6MB 1.5MB -26.9KB
visTypeMarkdown 12.9KB 12.9KB +58.0B
visTypeMetric 20.8KB 20.8KB +1.0B
visTypeTable 154.1KB 154.1KB +80.0B
visTypeTagcloud 284.7KB 284.7KB -1.0B
visTypeVislib 643.7KB 643.9KB +145.0B
visTypeXy 137.6KB 137.6KB +1.0B
total -26.6KB

Distributable file count

id before after diff
default 47486 48249 +763

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
charts 178.7KB 163.8KB -15.0KB
mapsLegacy 94.3KB 94.3KB +10.0B
regionMap 44.3KB 44.4KB +60.0B
tileMap 44.5KB 44.5KB +50.0B
triggersActionsUi 162.6KB 162.7KB +102.0B
visDefaultEditor 30.9KB 46.0KB +15.1KB
visTypeMarkdown 14.6KB 14.4KB -233.0B
visTypeMetric 26.3KB 26.4KB +85.0B
visTypeTable 11.7KB 11.5KB -233.0B
visTypeTagcloud 19.2KB 19.0KB -297.0B
total -287.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula merged commit c1fe466 into elastic:7.x Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants