Remove support for setting server.host to '0' (breaking) #87114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for this was originally a side-effect of our old version of hapi (pre v20). hapi v20 does no longer support this, so a workaround was added to not break expectations. This PR removes that workaround for v8.0.0 as it's considered a breaking change.
Besides, in the new version of joi,
0
is no longer considered a valid hostname, so when we upgrade, this extravalidate
function can be removed.Todo
0
as theirserver.host
(Use 0.0.0.0 instead of 0 as server.host elastic-package#211)0
0
??Release note
Removes support for configuring Kibana with
0
as theserver.host
.