[Fleet] Don't retry if icon isn't in initial response #88403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsiii
added
release_note:skip
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
jen-huang
approved these changes
Jan 14, 2021
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Jan 15, 2021
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Jan 15, 2021
jfsiii
pushed a commit
that referenced
this pull request
Jan 19, 2021
Co-authored-by: Kibana Machine <[email protected]>
jfsiii
pushed a commit
that referenced
this pull request
Jan 19, 2021
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #66226
Remove
tryApiparam fromPackageIcon, since response is from the Registry alreadykibana/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/step_select_package.tsx
Line 49 in 5e351db
Setting
tryApi={true}is just flooding the Registry with requests for items we know aren't there.Compare
master(note XHR requests forbluecoat, etc)master-packageicon.mp4
vs PR only SVG's requested
66226-PR.mp4