Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Reformats Dashboard and adds Lens reference #89615

Merged
merged 39 commits into from
Mar 18, 2021

Conversation

KOTungseth
Copy link
Contributor

@KOTungseth KOTungseth commented Jan 28, 2021

Summary

Part of #81780

This PR:

  • Reformats the Dashboard section
  • Adds a Lens-specific reference page
  • Adds the advanced (time series) Lens tutorial

+
[role="screenshot"]
image::images/lens_end_to_end_7_2.png[Treemap vis]
Inspecting {es} queries in visualizations is unsupported in *Lens*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this with the Inspector flow: Inpector => View: Request => Request ....?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already cover how to inspect visualizations on the Dashboard page, so this isn't needed.

@mbondyra
Copy link
Contributor

@elasticmachine merge upstream

@@ -102,6 +72,8 @@ Choose the type of panel you want to create, then save the panel to the dashboar

TIP: To access your saved panels, open the main menu, then click *Visualize Library*.

[[tsvb]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag seems to be in the wrong place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is! But that's because if it wasn't there, it would break a bunch of links.

docs/user/dashboard/vega.asciidoc Outdated Show resolved Hide resolved
docs/user/dashboard/tsvb.asciidoc Outdated Show resolved Hide resolved
The visualization is done, but the legend uses a lot of space. Change the legend position to the top of the chart.

. From the *Legend* dropdown, select the top position.
* *Pie*, *Donut*, and *Treemap*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly these chart types have extra options for value labels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's address this for 7.13.

.. Drag and drop *@timestamp* to the *Horizontal axis* field.
[float]
[[how-are-ip-address-sorted]]
===== How does Lens sort IP addresses?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This question looks like the kind of question we would get internally, but I think the question our users have is much more basic: it's usually "why isn't my data sorted the way I want?" or "why is the sorting not working?". This is because each Lens chart type sorts differently, and we need to how the data table sorting is not changing the ES results.

If you want to use IP addresses as an example of sorting, then feel free, but I think this answer needs to be expanded

@dej611

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing for 7.12. Let's address this for 7.13.

docs/user/dashboard/lens.asciidoc Show resolved Hide resolved
docs/user/dashboard/lens.asciidoc Show resolved Hide resolved

.. From the editor, click *Top values of geo.src*.
Sorting dimensions in visualizations is unsupported in *Lens*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really true with the table- left a comment about this earlier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing for 7.12. Let's address this for 7.13.

@KOTungseth KOTungseth marked this pull request as ready for review March 16, 2021 16:25
mbondyra and others added 3 commits March 17, 2021 13:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@KOTungseth KOTungseth merged commit 0e81121 into elastic:master Mar 18, 2021
@KOTungseth KOTungseth deleted the docs/lens-reference branch March 18, 2021 19:21
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 18, 2021
* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [Lens] Add drag and drop keyboard navigation docs

* remove unlinked files

* [Lens] tutorial advanced first version

* corrections

* Kaarinas changes

* corrections after CR

* Update docs/user/dashboard/lens-advanced.asciidoc

* 📝 Add more Lens related FAQ

* Updates Lens page

* Update docs/user/dashboard/lens.asciidoc

* drag and drop copy and gif

* some corrections after Wylie's second review

* Review comments

* Final changes

* Update lens-advanced.asciidoc

ordering fixed

* Comment organization

* Final clean up

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
KOTungseth added a commit to KOTungseth/kibana that referenced this pull request Mar 18, 2021
* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [Lens] Add drag and drop keyboard navigation docs

* remove unlinked files

* [Lens] tutorial advanced first version

* corrections

* Kaarinas changes

* corrections after CR

* Update docs/user/dashboard/lens-advanced.asciidoc

* 📝 Add more Lens related FAQ

* Updates Lens page

* Update docs/user/dashboard/lens.asciidoc

* drag and drop copy and gif

* some corrections after Wylie's second review

* Review comments

* Final changes

* Update lens-advanced.asciidoc

ordering fixed

* Comment organization

* Final clean up

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
KOTungseth added a commit that referenced this pull request Mar 18, 2021
* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [Lens] Add drag and drop keyboard navigation docs

* remove unlinked files

* [Lens] tutorial advanced first version

* corrections

* Kaarinas changes

* corrections after CR

* Update docs/user/dashboard/lens-advanced.asciidoc

* 📝 Add more Lens related FAQ

* Updates Lens page

* Update docs/user/dashboard/lens.asciidoc

* drag and drop copy and gif

* some corrections after Wylie's second review

* Review comments

* Final changes

* Update lens-advanced.asciidoc

ordering fixed

* Comment organization

* Final clean up

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
KOTungseth added a commit that referenced this pull request Mar 18, 2021
* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [DOCS] Reformats Dashboard and adds Lens reference

* ⚗️ First trial of Lens FAQ

* Fixes broken title levels

* Link fix

* Fixes tsvb link

* Fixes tsvb link

* [Lens] Add drag and drop keyboard navigation docs

* remove unlinked files

* [Lens] tutorial advanced first version

* corrections

* Kaarinas changes

* corrections after CR

* Update docs/user/dashboard/lens-advanced.asciidoc

* 📝 Add more Lens related FAQ

* Updates Lens page

* Update docs/user/dashboard/lens.asciidoc

* drag and drop copy and gif

* some corrections after Wylie's second review

* Review comments

* Final changes

* Update lens-advanced.asciidoc

ordering fixed

* Comment organization

* Final clean up

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
Co-authored-by: Marta Bondyra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.12.0 v7.13.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants