Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ts project refs: Migrates Upgrade Assistant to a TS project #89949

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Feb 2, 2021

Summary

Partially addresses #89321

Partial stats from running node --max-old-space-size=4096 ./node_modules/.bin/tsc -p x-pack/tsconfig.json --extendedDiagnostics --noEmit:

Before:
Files: 14891
Lines: 1609898

After:
Files: 14783
Lines: 1597047

@TinaHeiligers TinaHeiligers added chore v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 2, 2021
@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Feb 2, 2021

@sebelga I ran the flaky test several times locally and it passes every time. Do you happen to know why the order here matters?

stack trace:
Error: expected [ 'Advanced Settings [8.0.0-SNAPSHOT]',
  'Advanced Settings [6.0.0]',
  'A Dashboard',
  'logstash-*',
  'A Pie' ] to sort of equal [ 'Advanced Settings [6.0.0]',
  'Advanced Settings [8.0.0-SNAPSHOT]',
  'A Dashboard',
  'logstash-*',
  'A Pie' ]
    at Assertion.assert (/dev/shm/workspace/parallel/12/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/parallel/12/kibana/packages/kbn-expect/expect.js:244:8)
    at Context.<anonymous> (test/functional/apps/saved_objects_management/feature_controls/saved_objects_management_security.ts:189:30)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at Object.apply (/dev/shm/workspace/parallel/12/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16) {
  actual: '[\n' +
    '  "Advanced Settings [8.0.0-SNAPSHOT]"\n' +
    '  "Advanced Settings [6.0.0]"\n' +
    '  "A Dashboard"\n' +
    '  "logstash-*"\n' +
    '  "A Pie"\n' +
    ']',
  expected: '[\n' +
    '  "Advanced Settings [6.0.0]"\n' +
    '  "Advanced Settings [8.0.0-SNAPSHOT]"\n' +
    '  "A Dashboard"\n' +
    '  "logstash-*"\n' +
    '  "A Pie"\n' +
    ']',
  showDiff: true
}

@TinaHeiligers TinaHeiligers marked this pull request as ready for review February 2, 2021 14:38
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner February 2, 2021 14:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@rudolf
Copy link
Contributor

rudolf commented Feb 2, 2021

@TinaHeiligers the flaky test is my fault (v2 migrations) and should be fixed if you merge in master since v2 migrations have been disabled again in master tests.

Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, happy to merge when CI is done 👍🏻

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@TinaHeiligers TinaHeiligers merged commit c67e291 into elastic:master Feb 3, 2021
@TinaHeiligers TinaHeiligers deleted the ts-project-refs-es_ui/upgrade_assistant branch February 3, 2021 16:33
TinaHeiligers added a commit that referenced this pull request Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.12.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants