Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover: Add handling for source column #91815

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

flash1293
Copy link
Contributor

Fixes #91493
Fixes #91633

Makes sure the column list is always in sync with the current state of fields vs source fetching (removing the source column if it is present)

@flash1293 flash1293 added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 18, 2021
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

...state,
columns: state.columns.filter((column) => column !== '_source'),
};
} else if (state.columns.length === 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: else is redundant

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
discover 348 349 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 408.6KB 409.4KB +741.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review February 18, 2021 15:19
@flash1293 flash1293 requested a review from a team February 18, 2021 15:19
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 merged commit 543bf1b into elastic:master Feb 18, 2021
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 19, 2021
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 19, 2021
flash1293 added a commit that referenced this pull request Feb 19, 2021
* Discover: Add handling for source column (#91815)

* enable by default

* [Discover] Fix context view for date_nanos format with custom timestamps (#54089)

* Switch from _source to fields when fetching anchor records with date_nanos timestamps

* Add testdata

* Add functional test

* fix search_after

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Matthias Wilhelm <[email protected]>
flash1293 added a commit that referenced this pull request Feb 19, 2021
* Discover: Add handling for source column (#91815)

* enable by default

* fix conflicts

* fix search_after

* fix test

Co-authored-by: Kibana Machine <[email protected]>
Co-authored-by: Matthias Wilhelm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.12.0 v7.13.0 v8.0.0
Projects
None yet
4 participants