[Maps] Update Map extent queries to use bounding box logic for both point and shape queries #93156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
reviewed
Mar 2, 2021
x-pack/plugins/maps/common/elasticsearch_util/elasticsearch_geo_utils.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/common/elasticsearch_util/elasticsearch_geo_utils.test.js
Outdated
Show resolved
Hide resolved
x-pack/plugins/maps/common/elasticsearch_util/elasticsearch_geo_utils.test.js
Outdated
Show resolved
Hide resolved
thomasneirynck
approved these changes
Mar 2, 2021
added 2 commits
March 2, 2021 11:29
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Mar 2, 2021
…oint and shape queries (elastic#93156)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 3, 2021
* master: (45 commits) Add outcome of node scripts/build_api_docs (elastic#93399) [Lens] fix long field name on field stats panel doesn't wrap (elastic#93279) [Bug] Fix filter creation for numeric scripted fields in Discover (elastic#93224) [uptime] Fix anomaly alert edit (elastic#93025) Consolidate @babel/* packages and use latest compatible version (elastic#93264) [Search Embeddable] Add highlighting when searching (elastic#93178) [APM] Add missing bottom border to header (elastic#93179) [CI] No longer collect APM span stack traces (elastic#93263) [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (elastic#93024) update generated public api docs API DOCS Step 3/3 (elastic#92929) chore(NA): look for bazel packages on npm_module folder during distributable build (elastic#93262) rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (elastic#92620) [kbn/optimizer] allow customizing the limits path from the script (elastic#93153) [Alerting][Docs] Adding template for documenting alert and action types (elastic#92830) [jenkins] convert baseline capture job to use tasks (elastic#93288) removing the linked issue in comments from PR (elastic#93303) chore(NA): do not include fs within a storybook build (elastic#93294) [Maps] Update Map extent queries to use bounding box logic for both point and shape queries (elastic#93156) Add searchDuration to EQL and Threshold rules (elastic#93149) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #82480. Enables
geo_bounding_boxfor geo shape layers.To test:
Dynamically filter for data in the visible map area& finish adding layerNote: The original issue focused on consolidating the two extent filter construction paths into one, which is what this PR does, but it seems like we could also update the drawable bbox filters to use
geo_bounding_boxinstead ofgeo_shapewhich it does for both point and shape layers currently. Happy to discuss!