Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Fix reports embeddables #93482

Merged
merged 3 commits into from
Mar 4, 2021
Merged

[Canvas] Fix reports embeddables #93482

merged 3 commits into from
Mar 4, 2021

Conversation

crob611
Copy link
Contributor

@crob611 crob611 commented Mar 3, 2021

Summary

Maps in reports were having issues and it appears to be from repeated creation/add to dom of the embeddable.

This PR makes it so when an embeddable is being created, it won't try to re-create if the initial creation isn't done.

Corey Robertson added 2 commits March 2, 2021 16:54
@crob611 crob611 added bug Fixes for quality problems that affect the customer experience review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:Canvas v7.12.1 labels Mar 3, 2021
@crob611 crob611 requested a review from a team as a code owner March 3, 2021 18:26
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

poffdeluxe
poffdeluxe approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

x-pack/plugins/canvas/canvas_plugin_src/renderers/embeddable/embeddable.tsx
embeddablesRegistry[uniqueId].reload();
const embeddable = embeddablesRegistry[uniqueId];

if ('updateInput' in embeddable) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be cool if there was a nicer way to check to see if this was a promise or something but it'll work for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah agree with that. It's probably not a great practice for something to be thing or promise and instead just let it always be the promise? I dunno but agree it's worth revisiting.

@crob611
Copy link
Contributor Author

crob611 commented Mar 4, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
canvas 548.7KB 548.9KB +222.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@crob611 crob611 merged commit d673f56 into elastic:master Mar 4, 2021
@crob611 crob611 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 4, 2021
@kibanamachine kibanamachine mentioned this pull request Mar 4, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 4, 2021
@kibanamachine
[Canvas] Fix reports embeddables (elastic#93482)
5f8524f 
* wip

* WIP

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

✅ 7.12 / #93679

Successful backport PRs will be merged automatically after passing CI.

gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 4, 2021
@gmmorris
Merge branch 'master' into actions/terminology-api
55ff443 
* master: (107 commits)
  [Logs UI] Fix log stream data fetching (elastic#93201)
  [App Search] Added relevance tuning search preview (elastic#93054)
  [Canvas] Fix reports embeddables (elastic#93482)
  [ILM] Added new functional test in ILM for creating a new policy (elastic#92936)
  Remove direct dependency on statehood package (elastic#93592)
  [Maps] Track tile loading status (elastic#91585)
  [Discover][Doc] Improve main documentation (elastic#91854)
  [Upgrade Assistant] Disable UA and add prompt (elastic#92834)
  [Snapshot Restore] Remove cloud validation for slm policy (elastic#93609)
  [Maps] Support GeometryCollections in GeoJson upload (elastic#93507)
  [XY Charts] fix partial histogram endzones annotations (elastic#93091)
  [Core] Simplify context typings (elastic#93579)
  [Alerting] Improving health status check (elastic#93282)
  [Discover] Restore context documentation (elastic#90784)
  [core-docs] Edits core-intro section for the new docs system (elastic#93540)
  add missed codeowners (elastic#89714)
  fetch node labels via script execution (elastic#93225)
  [Security Solution] Adds getMockTheme function (elastic#92840)
  Sort dependencies in package.json correctly (elastic#93590)
  [Bug] missing timepicker:quickRanges migration (elastic#93409)
  ...
kibanamachine added a commit that referenced this pull request Mar 4, 2021
@kibanamachine
[Canvas] Fix reports embeddables (#93482) (#93679)
7088fa9 
* wip

* WIP

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Corey Robertson <[email protected]>
@tsullivan tsullivan mentioned this pull request May 13, 2021
Closed
@crob611 crob611 mentioned this pull request Aug 19, 2021
Closed
@crob611 crob611 added v7.14.1 v7.15.0 v7.16.0 and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Aug 24, 2021
This was referenced Aug 24, 2021
Merged
Merged
crob611 pushed a commit to crob611/kibana that referenced this pull request Aug 24, 2021
@kibanamachine
[Canvas] Fix reports embeddables (elastic#93482)
8c08cb1 
* wip

* WIP

Co-authored-by: Kibana Machine <[email protected]>
crob611 pushed a commit to crob611/kibana that referenced this pull request Aug 24, 2021
@kibanamachine
[Canvas] Fix reports embeddables (elastic#93482)
feaca84 
* wip

* WIP

Co-authored-by: Kibana Machine <[email protected]>
@crob611 crob611 mentioned this pull request Aug 24, 2021
Merged
crob611 pushed a commit to crob611/kibana that referenced this pull request Aug 24, 2021
@kibanamachine
[Canvas] Fix reports embeddables (elastic#93482)
087f3ed 
* wip

* WIP

Co-authored-by: Kibana Machine <[email protected]>
crob611 pushed a commit that referenced this pull request Aug 24, 2021
@kibanamachine
[Canvas] Fix reports embeddables (#93482) (#109955)
2d7b5c6 
* wip

* WIP

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
crob611 pushed a commit that referenced this pull request Aug 24, 2021
@kibanamachine
[Canvas] Fix reports embeddables (#93482) (#109953)
92099b7 
* wip

* WIP

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
crob611 pushed a commit that referenced this pull request Aug 25, 2021
@kibanamachine
[Canvas] Fix reports embeddables (#93482) (#109952)
0a7b8ca 
* wip

* WIP

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poffdeluxe poffdeluxe poffdeluxe approved these changes

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.12.1 v7.14.1 v7.15.0 v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crob611 @elasticmachine @kibanamachine @poffdeluxe