Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Constant and dynamic threshold lines #94569

Closed

Conversation

flash1293
Copy link
Contributor

This PR adds constant and dynamic threshold lines.

It's a very rough POC investigating which kinds of issues pop up.

Configuration:
Screenshot 2021-03-15 at 14 52 32

Static thresholds:
Screenshot 2021-03-15 at 14 54 09

Dynamic thresholds:
Screenshot 2021-03-15 at 14 54 57

Takeaways

  • Dynamic threshold are much easier to implement because they are super close to how regular layers work
  • Constant thresholds require much more changes, because a lot of code assumes the presence of a datasource layer - still possible to pull off because it's mostly skipping things.
  • It would be pretty hard to transition between the two types of layers - is it OK to have separate ones? Will user understand?

[skip ci]

@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Mar 15, 2021
@flash1293
Copy link
Contributor Author

Moved to #95612

@flash1293 flash1293 closed this Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant