LIR: merge hash attributes of same name to support legacy configurations #8602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A [build failure][] of the grok plugin when run through LIR/lscl indicates that there is an expectation for multiple Attributes of the same name to be merged together. This commit ports the failing spec in the plugin to an abstraction that can be tested within logstash-core, and adds a caveat to the LSCL LIR-builder to ensure that we merge the hashes in a way that is compatible with legacy behaviour. NOTE: when multiple Attributes of the same name are used in a single config, it's possible to create configurations that circumvent `AST::Hash`'s ability to report duplicate keys. [build failure]: https://travis-ci.org/logstash-plugins/logstash-filter-grok/builds/293778268 Backports elastic#8597
yaauie
commented
Nov 8, 2017
| # (NOTE: this bypasses `AST::Hash`'s ability to detect duplicate keys) | ||
| hash[k] = existing.merge(v) | ||
| else | ||
| hash[k] = existing + v |
There was a problem hiding this comment.
note: this also backports an intermediate fix that supports the similar behaviour when multiple Attributes with the same name produce Arrays
|
Ry Biesemeyer merged this into the following branches!
|
elasticsearch-bot
pushed a commit
that referenced
this pull request
Nov 8, 2017
A [build failure][] of the grok plugin when run through LIR/lscl indicates that there is an expectation for multiple Attributes of the same name to be merged together. This commit ports the failing spec in the plugin to an abstraction that can be tested within logstash-core, and adds a caveat to the LSCL LIR-builder to ensure that we merge the hashes in a way that is compatible with legacy behaviour. NOTE: when multiple Attributes of the same name are used in a single config, it's possible to create configurations that circumvent `AST::Hash`'s ability to report duplicate keys. [build failure]: https://travis-ci.org/logstash-plugins/logstash-filter-grok/builds/293778268 Backports #8597 Fixes #8602
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #8597 to 6.0