lib: return informative error for invalid extremum input #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
the
Team:Security-External Integrations
6 tasks
kcreddy
added a commit
to elastic/integrations
that referenced
this pull request
Aug 23, 2024
…rror (#10861) Fix `max()` calculation on empty resources leading to error. Due to change made in [`mito`](elastic/mito#65), the `max()`function now returns an error message `no extremum of empty list` when it is applied on empty `[]` list. This `mito` change is applied to `8.15.0` Stack. While this error message is extremely useful, the current CEL program in `ti_crowdstrike` doesn't check for empty list. This leads to an error while otherwise could have been a `null` value in Stack version `< 8.15.0`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take a look.