Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Proposal] Make version optional in package manifests #723

Open
jsoriano opened this issue Mar 1, 2024 · 2 comments
Open

[Change Proposal] Make version optional in package manifests #723

jsoriano opened this issue Mar 1, 2024 · 2 comments
Labels
discuss Issue needs discussion

Comments

@jsoriano
Copy link
Member

jsoriano commented Mar 1, 2024

Proposal

Make version optional in package manifests.

Why?

In the vast majority of cases (if not all) version is redundant with the latest version in the changelog. Package developers are forced to manually keep these values coherent.
This has been reported as a common papercut for contributions in packages, specially for external contributors.

How?

We would make version optional in package manifest for backwards compatibility, and maybe remove it in a following major. In the cases where the version is not set in the manifest, the version of the package would be just the version at the top of the changelog (assuming it is correctly ordered).
elastic-package could maybe add the version to the manifest in built packages in case it helps on package publication, discovery and so on.

We need to assess the changes needed in package spec, elastic package, package registry and fleet.

Take also into account the use cases of the -next suffix.

Related issues

@jsoriano jsoriano added the discuss Issue needs discussion label Mar 1, 2024
@jlind23
Copy link
Collaborator

jlind23 commented Apr 2, 2024

@jsoriano Shall we ping more packages developers here in order to get feedbacks?

@jsoriano
Copy link
Member Author

jsoriano commented Apr 2, 2024

@jsoriano Shall we ping more packages developers here in order to get feedbacks?

This issue comes from direct feedback from package developers, and the initial idea would be to make it optional, so if there is some case that requires both versions as now, it will be still supported.

Once we have all the pieces to make it optional, I agree with broadening the discussion about removing it in a potential v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs discussion
Projects
None yet
Development

No branches or pull requests

2 participants