Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds ELSER benchmark info #2472

Merged
merged 6 commits into from
Jul 19, 2023
Merged

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jul 14, 2023

Overview

This PR "harvests" the benchmark info from the ELSER blog post and adds it to the ELSER conceptual docs.

Preview

ELSER benchmarks

@szabosteve szabosteve added :ml WIP Work in progress nlp ELSER backport-8.8 Automated backport with mergify v8.9.0 v8.8.2 backport-8.9 Automated backport with mergify v8.10 labels Jul 14, 2023
@github-actions
Copy link

Documentation preview:

@szabosteve szabosteve requested review from pquentin and qherreros and removed request for pquentin July 17, 2023 09:02
@szabosteve szabosteve marked this pull request as ready for review July 17, 2023 09:30
=== Qualitative benchmarks

The metric that is used to evaluate ELSER's ranking ability is the Normalized
Discounted Cumulative Gain (NDCG), which is the most complete metric as it can

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace "the most complete metric" by "an interesting metric". There might be some obscure metric capturing something similar than NDCG and you could argue than NDCG is only looking at relevancy which is not a complete picture of information retrieval (you could add performance, index size, ...). But I'm being picky maybe !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the suggestion and the explanation, @qherreros. I addressed in c29b337. Eventually, I removed the adjective from the sentence and didn't replace it with another one. Let me know if you'd like to add or remove anything!

Copy link

@qherreros qherreros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@szabosteve szabosteve merged commit 171d1e8 into elastic:main Jul 19, 2023
1 check passed
@szabosteve szabosteve deleted the elser-benchmarks branch July 19, 2023 11:59
mergify bot pushed a commit that referenced this pull request Jul 19, 2023
mergify bot pushed a commit that referenced this pull request Jul 19, 2023
szabosteve added a commit that referenced this pull request Jul 19, 2023
(cherry picked from commit 171d1e8)

Co-authored-by: István Zoltán Szabó <[email protected]>
szabosteve added a commit that referenced this pull request Jul 19, 2023
(cherry picked from commit 171d1e8)

Co-authored-by: István Zoltán Szabó <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.8 Automated backport with mergify backport-8.9 Automated backport with mergify ELSER :ml nlp v8.8.2 v8.9.0 v8.10 WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants