Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch releases shasum files to SHA256 for SHA1 is not safe anymore #454

Closed
RicardoGralhoz opened this issue Nov 13, 2020 · 0 comments · Fixed by #662
Closed

Switch releases shasum files to SHA256 for SHA1 is not safe anymore #454

RicardoGralhoz opened this issue Nov 13, 2020 · 0 comments · Fixed by #662
Assignees
@danleerunk
Labels
diagnostic

Comments

@RicardoGralhoz
Copy link

RicardoGralhoz commented Nov 13, 2020 •
edited
Loading

Hi, the Releases page as of today use a support-diagnostic-XX.XX.XX-dist.zip.sha1 file for shasum checks. The article Announcing the first SHA1 collision announced in 2017 a

first practical technique for generating a collision

and recommends

the industry that it is urgent to move to safer alternatives such as SHA-256

This seems like a low hanging fruit. Have you considered moving it to SHA-256?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danleerunk danleerunk

Labels
diagnostic
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use sha-256 for generating release checksums (#454) cleydyr/support-diagnostics
4 participants
@chason @RicardoGralhoz @danleerunk @cory-mangini