Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for new UI #1986

Merged
merged 32 commits into from
May 26, 2024
Merged

Fixes for new UI #1986

merged 32 commits into from
May 26, 2024

Conversation

Cyteon
Copy link
Collaborator

@Cyteon Cyteon commented Mar 20, 2024 •
edited
Loading

Description

This should fix all issues with the new ui!

Issue Fixes

Should fix:

Checklist:

  • [V] I am pushing changes to the develop branch
  • [V] I am using the recommended development environment
  • [V] I have performed a self-review of my own code
  • [V] I have commented my code, particularly in hard-to-understand areas
  • [V] I have formatted and linted my code using python-black and pylint
  • [V] I have cleaned up unnecessary files
  • [V] My changes generate no new warnings
  • [V] My changes follow the existing code-style
  • [V] My changes are relevant to the project

Any other information (e.g how to test the changes)

None

@Cyteon
Copy link
Collaborator Author

Cyteon commented Mar 22, 2024

the memes support commit is not supposed to be there

@Cyteon
Revert "meme support"
410f442 
This reverts commit b508f2a.
@Cyteon
Copy link
Collaborator Author

Cyteon commented Mar 22, 2024

reverted, ready to be merged

@github-actions github-actions bot added the stale label Mar 29, 2024
@JasonLovesDoggo JasonLovesDoggo added enhancement New feature or request before next release Issue must be solved / PR must be merged before next release keep and removed stale labels Apr 1, 2024
@LevaniVashadze
Copy link
Contributor

Why is it not headless anymore?

OpenSourceSimon
OpenSourceSimon requested changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@OpenSourceSimon OpenSourceSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it, but looks great! Visited the website new.reddit.com, looks exactly like the old lay-out!

video_creation/data/videos.json
@@ -1 +0,0 @@
[]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this change? If I believe correctly, this will cause the bot to crash.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the file, it was not there originally

video_creation/screenshot_downloader.py Show resolved Hide resolved
video_creation/screenshot_downloader.py Show resolved Hide resolved
@github-actions github-actions bot added the stale label Apr 10, 2024
@dsaderholm
Copy link

Hey, it seems like new.reddit.com with // is redirecting to old Reddit now. Am I the only one with this issue?

MagicHatJo and others added 13 commits April 26, 2024 18:34
@MagicHatJo
fix: Fixes elebumm#1812, random_voice True/False acceptance
1b146ab
@JasonLovesDoggo
fix: fixed the GUI
35fac14 
chore: reformatted and optimized imports.

Co-authored-by: Jan Tumpa <[email protected]>
@dependabot
Bump unidecode from 1.3.6 to 1.3.8
fb49acd 
Bumps [unidecode](https:/kmike/text-unidecode) from 1.3.6 to 1.3.8.
- [Release notes](https:/kmike/text-unidecode/releases)
- [Commits](https:/kmike/text-unidecode/commits)

---
updated-dependencies:
- dependency-name: unidecode
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump transformers from 4.29.2 to 4.37.1
c84e34e 
Bumps [transformers](https:/huggingface/transformers) from 4.29.2 to 4.37.1.
- [Release notes](https:/huggingface/transformers/releases)
- [Commits](huggingface/transformers@v4.29.2...v4.37.1)

---
updated-dependencies:
- dependency-name: transformers
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@github-actions
fixup: Format Python code with Black
bbf5a82
@dependabot
Bump pillow from 9.5.0 to 10.2.0
f827f9f 
Bumps [pillow](https:/python-pillow/Pillow) from 9.5.0 to 10.2.0.
- [Release notes](https:/python-pillow/Pillow/releases)
- [Changelog](https:/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@9.5.0...10.2.0)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump torch from 2.0.1 to 2.2.0
37faf2a 
Bumps [torch](https:/pytorch/pytorch) from 2.0.1 to 2.2.0.
- [Release notes](https:/pytorch/pytorch/releases)
- [Changelog](https:/pytorch/pytorch/blob/main/RELEASE.md)
- [Commits](pytorch/pytorch@v2.0.1...v2.2.0)

---
updated-dependencies:
- dependency-name: torch
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump gtts from 2.3.2 to 2.5.1
d15740d 
Bumps [gtts](https:/pndurette/gTTS) from 2.3.2 to 2.5.1.
- [Release notes](https:/pndurette/gTTS/releases)
- [Changelog](https:/pndurette/gTTS/blob/main/CHANGELOG.md)
- [Commits](pndurette/gTTS@v2.3.2...v2.5.1)

---
updated-dependencies:
- dependency-name: gtts
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump transformers from 4.37.1 to 4.37.2
cdf8ad2 
Bumps [transformers](https:/huggingface/transformers) from 4.37.1 to 4.37.2.
- [Release notes](https:/huggingface/transformers/releases)
- [Commits](huggingface/transformers@v4.37.1...v4.37.2)

---
updated-dependencies:
- dependency-name: transformers
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@Cyteon
meme support
d42ff50
@Cyteon
Revert "meme support"
903081f 
This reverts commit b508f2a.
Merge conflict fix
bc0abb6
@Cyteon
Git merge conflict was not actually resolved
64f2322
@Faycal-S Faycal-S mentioned this pull request May 14, 2024
Closed
2 tasks
@Faycal-S
Copy link

Behavior is not consistent for me unfortunately. It works sometimes but doesn't work sometimes :/
I noticed in headless=False mode that when it doesn't work, it's failing to login to reddit..
Any ideas?

@dsaderholm
Copy link

Behavior is not consistent for me unfortunately. It works sometimes but doesn't work sometimes :/ I noticed in headless=False mode that when it doesn't work, it's failing to login to reddit.. Any ideas?

I am having the same issue. Sometimes it works, sometimes it doesn't.

@Cyteon
Copy link
Collaborator Author

Cyteon commented May 19, 2024

Known issue

@Cyteon Cyteon mentioned this pull request May 19, 2024
Merged
9 tasks
@Cyteon Cyteon merged commit 64f2322 into elebumm:develop May 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OpenSourceSimon OpenSourceSimon Awaiting requested review from OpenSourceSimon

Assignees
No one assigned
Labels
before next release Issue must be solved / PR must be merged before next release enhancement New feature or request keep stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Cyteon @LevaniVashadze @dsaderholm @Faycal-S @OpenSourceSimon @JasonLovesDoggo @dyogenez @MagicHatJo