-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Envelope timings incorrect #185
Comments
Hi Florian, The ADSR is ported from here (https://paulbatchelor.github.io/res/soundpipe/docs/adsr.html). NOTE: The attack, decay, and release parameters are "fuzzy" values that don't exactly correspond to duration in seconds. More accurately, they are special tau constant units that feed into the filter used to generate the envelope. The attack value specificly undergoes some "creative" modificiations in order to create snappier attack times. It is highly recommend to tune parameters by ear rather than to read the values literally. For more reference: We could clarify all of this in a documentation, comments in the example code, and etc. |
Looks like
attack
is in seconds butdecay
andrelease
are off by a factor of ~5 w.r.t. them being seconds.Is this a know issue / intended?
The text was updated successfully, but these errors were encountered: