Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adenv crashes with segment times = 0 #78

Open
andrewikenberry opened this issue Oct 28, 2020 · 4 comments
Open

Adenv crashes with segment times = 0 #78

andrewikenberry opened this issue Oct 28, 2020 · 4 comments
Labels
bug Something isn't working module

Comments

@andrewikenberry
Copy link
Member

andrewikenberry commented Oct 28, 2020

As dicussed on the Daisy forum.

@andrewikenberry andrewikenberry added the bug Something isn't working label Oct 28, 2020
@andrewikenberry
Copy link
Member Author

Fix AdEnv non-zero issue

@sdiedrichsen
Copy link
Contributor

This should have been fixed with my remake, which has been merge recently.

@makingsoundmachines
Copy link

I'm having some issues with the ADenv as it is right now:

  • with long release times, a decay tied to a pot (via parameter) will sometimes get "stuck" and keep passing the audio through;
  • with very short times close to 0.0 (e.g. 0.0001) and other DSP load going on, I get audio glitches that are gone at more moderate, "middle of the road" segment times

A suggestion (as discussed in the electrosmith slack) would be to apply @sdiedrichsen 's ADSR fix to the ADenv as well: #160

@makingsoundmachines
Copy link

A lower limit for segment values of 0.0005 (for ADENV_SEG_ATTACK / ADENV_SEG_DECAY) fixed the issues I was having.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working module
Projects
None yet
Development

No branches or pull requests

5 participants