Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(publisher-s3): typo makes argument not match the variable name #194

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix(publisher-s3): typo makes argument not match the variable name #194

merged 1 commit into from
Sep 17, 2024

Conversation

robinjhuang
Copy link
Contributor

No description provided.

erickzhao
erickzhao approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @robinjhuang !

@erickzhao erickzhao changed the title Fixed: typo makes argument not match the variable name fix(publisher-s3): typo makes argument not match the variable name Sep 17, 2024
@erickzhao erickzhao merged commit fe28804 into electron-forge:v6 Sep 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robinjhuang @erickzhao