fix: add CodeSigningAccountName as required prop in Azure Signing O…

…ptions (#8533) Ref: #8276 (comment)
electron-userland · Sep 24, 2024 · cc8c70f · cc8c70f
1 parent eaf274d
commit cc8c70f
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 1 deletion.
diff --git a/.changeset/real-otters-sparkle.md b/.changeset/real-otters-sparkle.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: add `CodeSigningAccountName` as required prop in Azure Signing Options
diff --git a/packages/app-builder-lib/scheme.json b/packages/app-builder-lib/scheme.json
@@ -5977,13 +5977,18 @@
  "description": "The Certificate Profile name. Translates to field: CertificateProfileName",
  "type": "string"
  },
+ "codeSigningAccountName": {
+ "description": "The Code Signing Signing Account name. Translates to field: CodeSigningAccountName",
+ "type": "string"
+ },
  "endpoint": {
  "description": "The Trusted Signing Account endpoint. The URI value must have a URI that aligns to the\nregion your Trusted Signing Account and Certificate Profile you are specifying were created\nin during the setup of these resources.\n\nTranslates to field: Endpoint\n\nRequires one of environment variable configurations for authenticating to Microsoft Entra ID per [Microsoft's documentation](https://learn.microsoft.com/en-us/dotnet/api/azure.identity.environmentcredential?view=azure-dotnet#definition)",
  "type": "string"
  }
  },
  "required": [
  "certificateProfileName",
+ "codeSigningAccountName",
  "endpoint"
  ],
  "type": "object"

diff --git a/packages/app-builder-lib/src/codeSign/windowsSignAzureManager.ts b/packages/app-builder-lib/src/codeSign/windowsSignAzureManager.ts
@@ -79,12 +79,13 @@ export class WindowsSignAzureManager {
  const vm = await this.packager.vm.value
  const ps = await getPSCmd(vm)
 
- const { endpoint, certificateProfileName, ...extraSigningArgs }: WindowsAzureSigningConfiguration = options.options.azureSignOptions!
+ const { endpoint, certificateProfileName, codeSigningAccountName, ...extraSigningArgs }: WindowsAzureSigningConfiguration = options.options.azureSignOptions!
  const params = {
  FileDigest: "SHA256",
  ...extraSigningArgs, // allows overriding FileDigest if provided in config
  Endpoint: endpoint,
  CertificateProfileName: certificateProfileName,
+ CodeSigningAccountName: codeSigningAccountName,
  Files: options.path,
  }
  const paramsString = Object.entries(params)

diff --git a/packages/app-builder-lib/src/options/winOptions.ts b/packages/app-builder-lib/src/options/winOptions.ts
@@ -203,6 +203,10 @@ export interface WindowsAzureSigningConfiguration {
  * The Certificate Profile name. Translates to field: CertificateProfileName
  */
  readonly certificateProfileName: string
+ /**
+ * The Code Signing Signing Account name. Translates to field: CodeSigningAccountName
+ */
+ readonly codeSigningAccountName: string
  /**
  * Allow other CLI parameters (verbatim case-sensitive) to `Invoke-TrustedSigning`
  */

diff --git a/test/src/windows/winCodeSignTest.ts b/test/src/windows/winCodeSignTest.ts
@@ -123,6 +123,7 @@ test.ifAll.ifNotCiMac(
  azureSignOptions: {
  endpoint: "https://weu.codesigning.azure.net/",
  certificateProfileName: "profilenamehere",
+ codeSigningAccountName: "codesigningnamehere"
  },
  },
  },