Skip to content

Commit

Permalink
fix(template-webpack): use css-loader instead of file-loader (#1036)
Browse files Browse the repository at this point in the history
This is not as optimal (the CSS ends up embedded in the JS file built by webpack), but it works.
  • Loading branch information
shimaore authored and malept committed Jul 18, 2019
1 parent 57ca285 commit 62b7c19
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/template/webpack/src/WebpackTemplate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ class WebpackTemplate implements ForgeTemplate {
`@electron-forge/plugin-webpack@${currentVersion}`,
// TODO: Use the @zeit publish once https:/zeit/webpack-asset-relocator-loader/pull/41 has been merged
'@marshallofsound/webpack-asset-relocator-loader@^0.5.0',
'file-loader@^4.0.0',
'css-loader@^3.0.0',
'node-loader@^0.6.0',
'style-loader@^0.23.1',
];
Expand Down
2 changes: 1 addition & 1 deletion packages/template/webpack/tmpl/webpack.renderer.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const rules = require('./webpack.rules');

rules.push({
test: /\.css$/,
use: [{ loader: 'style-loader/url' }, { loader: 'file-loader' }],
use: [{ loader: 'style-loader' }, { loader: 'css-loader' }],
});

module.exports = {
Expand Down

0 comments on commit 62b7c19

Please sign in to comment.