fix: ensure that files/folders whose names are properties of Object.prototype are packaged/extracted correctly #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pretty sure the test failure is git messing with me, I'll check it out when I get a chance |
|
Turns out it was an issue with the trailing line endings my editor was adding, looks like Windows on CI was creating a file with line endings which were different from the ones in my local Windows? Anyway, the PR is ready to review now. |
erikian
force-pushed
the
fix/properties-from-prototype
branch
from
9768cf0
to
1b9315a
Compare
BlackHole1
approved these changes
Sep 25, 2023
dsanders11
approved these changes
Sep 27, 2023
…rototype are packaged/extracted correctly
erikian
force-pushed
the
fix/properties-from-prototype
branch
from
1b9315a
to
63f6794
Compare
|
🎉 This PR is included in version 3.2.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #235, folders (and also files) named
constructorwere not being packaged. This happened because the objects holding the directory tree were being created with{}, which inherits all properties fromObject.prototype, such asconstructorand__proto__, so when trying to add a folder namedconstructor, it was assumed it already existed. Now we're creating these objects without a prototype withObject.create(null), so there shouldn't be any more conflicts.Fixes #235.