Add object files to default ignore patterns

Avoid the step of having to ignore .o files when signing the app for OSX. Also ignore Windows .obj files.
electron · Sep 16, 2016 · 395c512 · 395c512
1 parent 61dae6f
commit 395c512
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/ignore.js b/ignore.js
@@ -8,7 +8,8 @@ const DEFAULT_IGNORES = [
  '/node_modules/electron-prebuilt($|/)',
  '/node_modules/electron-packager($|/)',
  '/\\.git($|/)',
- '/node_modules/\\.bin($|/)'
+ '/node_modules/\\.bin($|/)',
+ '\\.o(bj)?$'
 ]
 
 function generateIgnores (opts) {

diff --git a/test/fixtures/basic/ignore.o b/test/fixtures/basic/ignore.o
diff --git a/test/fixtures/basic/ignore.obj b/test/fixtures/basic/ignore.obj
diff --git a/test/ignore.js b/test/ignore.js
@@ -17,7 +17,9 @@ function createIgnoreTest (opts, ignorePattern, ignoredFile) {
 
  opts.name = 'basicTest'
  opts.dir = util.fixtureSubdir('basic')
- opts.ignore = ignorePattern
+ if (ignorePattern) {
+ opts.ignore = ignorePattern
+ }
 
  var appPath
 
@@ -139,6 +141,8 @@ test('generateOutIgnores ignores all possible platform/arch permutations', (t) =
  t.end()
 })
 
+util.testSinglePlatform('ignore default test: .o files', createIgnoreTest, null, 'ignore.o')
+util.testSinglePlatform('ignore default test: .obj files', createIgnoreTest, null, 'ignore.obj')
 util.testSinglePlatform('ignore test: string in array', createIgnoreTest, ['ignorethis'],
  'ignorethis.txt')
 util.testSinglePlatform('ignore test: string', createIgnoreTest, 'ignorethis', 'ignorethis.txt')