Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System check doesn't work with yarn nightlies #334

Closed
3 tasks done
malept opened this issue Sep 25, 2017 · 1 comment
Closed
3 tasks done

System check doesn't work with yarn nightlies #334

malept opened this issue Sep 25, 2017 · 1 comment
Labels

Comments

@malept
Copy link
Member

malept commented Sep 25, 2017

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

Yarn nightlies don't follow semver, so the package manager version check fails. It will fail on any Forge subcommand because the system check always runs.

Example output (on Windows):

An unhandled error has occurred inside Forge:
Invalid Version: 1.1.0-20170925.1016

TypeError: Invalid Version: 1.1.0-20170925.1016

   at new SemVer (C:\Users\IEUser\projects\electronapp\node_modules\semver\semver.js:293:11)
   at Range.test (C:\Users\IEUser\projects\electronapp\node_modules\semver\semver.js:1100:15)
   at Function.satisfies (C:\Users\IEUser\projects\electronapp\node_modules\semver\semver.js:1149:16)
   at warnIfPackageManagerIsntAKnownGoodVersion (C:\Users\IEUser\projects\electronapp\node_modules\electron-forge\dist\util\check-system.js:111:25)
   at C:\Users\IEUser\projects\electronapp\node_modules\electron-forge\dist\util\check-system.js:72:17
   at process._tickCallback (internal/process/next_tick.js:103:7)
error Command failed with exit code 1.
@malept malept added the bug label Sep 25, 2017
@malept
Copy link
Member Author

malept commented Sep 25, 2017

Talked to @MarshallOfSound and we should warn on any nightly version.

dsanders11 pushed a commit that referenced this issue Jan 14, 2023
build: cache/install node deps per Travis docs, remove deprecated option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant