Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.X] Allow web-multi-logger port to be configurable #725

Closed
3 tasks done
R-NK opened this issue Apr 2, 2019 · 9 comments
Closed
3 tasks done

[6.X] Allow web-multi-logger port to be configurable #725

R-NK opened this issue Apr 2, 2019 · 9 comments

Comments

@R-NK
Copy link
Contributor

R-NK commented Apr 2, 2019

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:
@electron-forge/web-multi-logger is using port 9000, but same port is used by VSCode Extension on my machine. When I run yarn run start without killing the vscode process, I got this error:

An unhandled exception has occurred inside Forge:
listen EADDRINUSE: address already in use :::9000
Error: listen EADDRINUSE: address already in use :::9000
    at Server.setupListenHandle [as _listen2] (net.js:1290:14)
    at listenInCluster (net.js:1338:12)
    at Server.listen (net.js:1425:7)
    at Function.serverListen [as listen] (/Users/right/workspace/electron/electron-react-ts/node_modules/express-ws/lib/index.js:42:40)
    at listen (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/web-multi-logger/src/Logger.ts:46:30)
    at new Promise (<anonymous>)
    at Logger.start (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/web-multi-logger/src/Logger.ts:45:12)
    at start (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/plugin-webpack/src/WebpackPlugin.ts:414:18)
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/plugin-webpack/dist/WebpackPlugin.js:46:103)
    at _next (/Users/right/workspace/electron/electron-react-ts/node_modules/@electron-forge/plugin-webpack/dist/WebpackPlugin.js:48:194)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  electron-forge:plugin:webpack handling process exit with: { cleanup: true } +2s
  electron-forge:plugin:webpack cleaning webpack watcher +1ms
  electron-forge:plugin:webpack cleaning http server +0ms
  electron-forge:plugin:webpack stopping logger +1ms

Would you allow this port to be configurable or are there any workarounds for this?

@MarshallOfSound
Copy link
Member

PRs welcome 👍

The code in question is here --> https:/electron-userland/electron-forge/blob/master/packages/utils/web-multi-logger/src/Logger.ts

An environment variable probably makes the most sense here

@R-NK
Copy link
Contributor Author

R-NK commented Apr 3, 2019

Thank you for your reply, I'll address this issue.

R-NK added a commit to R-NK/electron-forge that referenced this issue Apr 3, 2019
R-NK added a commit to R-NK/electron-forge that referenced this issue Apr 3, 2019
R-NK added a commit to R-NK/electron-forge that referenced this issue Apr 3, 2019
malept pushed a commit that referenced this issue Apr 3, 2019
malept pushed a commit that referenced this issue Apr 3, 2019
@tborychowski
Copy link

I have this issue in a clean install of the latest version.

@malept
Copy link
Member

malept commented Jun 13, 2019

@tborychowski what is "the latest version"?

@tborychowski
Copy link

@malept version 5.2.4

@malept
Copy link
Member

malept commented Jun 13, 2019

As indicated in the issue title, this is for 6.x, not <= 5.

@tborychowski
Copy link

@malept In that case - sorry that I've got this problem in 5...

@malept
Copy link
Member

malept commented Jun 13, 2019

Well that's weird mostly because this feature doesn't exist at all in < 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants