Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template-webpack): use css-loader instead of file-loader #1036

Merged
merged 3 commits into from
Jul 18, 2019
Merged

fix(template-webpack): use css-loader instead of file-loader #1036

merged 3 commits into from
Jul 18, 2019

Commits on Jul 17, 2019

  1. template-webpack: add css-loader dependency

    @shimaore
    shimaore authored Jul 17, 2019
    Configuration menu
    Copy the full SHA
    aeeb163 View commit details
    Browse the repository at this point in the history

  2. use css-loader instead of file-loader 

    This is not as optimal (the CSS ends up embedded in the JS file built by webpack), but it should work.
    @shimaore
    shimaore authored Jul 17, 2019
    Configuration menu
    Copy the full SHA
    ea61a6b View commit details
    Browse the repository at this point in the history

  3. Update packages/template/webpack/src/WebpackTemplate.ts 

    Co-Authored-By: Mark Lee <[email protected]>
    @shimaore @malept
    shimaore and malept authored Jul 17, 2019
    Configuration menu
    Copy the full SHA
    9ba86ed View commit details
    Browse the repository at this point in the history