Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-typescript-webpack): adjust ts-loader module rule syntax #1388

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

malept
Copy link
Member

@malept malept commented Jan 9, 2020

Summarize your changes:

ts-loader was not being loaded for TypeScript files.

Also, be more strict about the exclude regex.

ISSUES CLOSED: #1378

ts-loader was not being loaded for TypeScript files

ISSUES CLOSED: #1378
@codecov
Copy link

codecov bot commented Jan 9, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@9f66342). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1388   +/-   ##
=========================================
  Coverage          ?   70.08%           
=========================================
  Files             ?       72           
  Lines             ?     2099           
  Branches          ?      389           
=========================================
  Hits              ?     1471           
  Misses            ?      454           
  Partials          ?      174

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f66342...c29b006. Read the comment docs.

@malept malept merged commit 1df9871 into master Jan 9, 2020
@malept malept deleted the typescript-webpack-rules-fix branch January 9, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template typescript-webpack does not startup correctly
1 participant