-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: vscode debugging shell file #2908
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2908 +/- ##
==========================================
- Coverage 71.82% 71.69% -0.13%
==========================================
Files 79 79
Lines 2385 2392 +7
Branches 449 450 +1
==========================================
+ Hits 1713 1715 +2
- Misses 450 548 +98
+ Partials 222 129 -93
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
It would be good if someone could test the following scenarios before merging:
|
Additionally the PR title does not conform to conventional commits standards as per the contributing docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holding on this based on my comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking a look @malept & @VerteDinde. Can you help me define a test plan @VerteDinde? I want to make sure we're testing the exact same way to ensure parity. Also, if you could help me with Ubuntu, I'd greatly appreciate it (no linux environment for me). 😅 @malept , what differences are you seeing between a mono repo and a stand alone git repo? |
The |
So, you'd just like me to simulate a repo with various directories and the Something like this?
I wanted to also point out that I'm really just reverting it back before this PR: #536 |
I don't think simulation is very realistic, by definition. Using actual monorepo managers is preferred. |
Hey @VerteDinde, I followed up with @malept to see what specifically needs to be tested to verify this change. I don't have an Ubuntu environment. If you could help me test the Ubuntu flow, I'd appreciate it! 😄 Here is the test matrix that needs to be tested: Just to be transparent, this experience is currently broken and it is a documented as being supported here. I'll tackle the macos experience and circle back. Thanks to all! |
@wesyao Sure thing! I'll give these a test on Ubuntu next week (PST), and will report back here 🙂 |
This should be resolved by electron-forge/electron-forge-docs#131, so closing this out - if there's still a problem here, feel free to ping me and I'll re-open. |
Summarize your changes:
The debugging experience is broken on mac/linux and was introduced #535.
There has been a request for this issue #1369.