Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-webpack): use new plugin syntax #2990

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

georgexu99
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #2990 (f4657f0) into main (362099a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2990      +/-   ##
==========================================
- Coverage   73.80%   73.80%   -0.01%     
==========================================
  Files          66       67       +1     
  Lines        2142     2168      +26     
  Branches      424      436      +12     
==========================================
+ Hits         1581     1600      +19     
- Misses        356      361       +5     
- Partials      205      207       +2     
Impacted Files Coverage Δ
packages/template/webpack/src/WebpackTemplate.ts 100.00% <100.00%> (ø)
packages/plugin/webpack/src/WebpackConfig.ts 94.62% <0.00%> (-4.10%) ⬇️
packages/api/core/src/util/plugin-interface.ts 31.11% <0.00%> (-0.71%) ⬇️
packages/plugin/webpack/src/WebpackPlugin.ts 37.93% <0.00%> (-0.07%) ⬇️
...kages/plugin/webpack/src/util/rendererTypeUtils.ts 100.00% <0.00%> (ø)
packages/api/core/src/api/make.ts 79.20% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362099a...f4657f0. Read the comment docs.

Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants