feat(generic): use an ora/promise helper instead of a global uncaughtRejection handler #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malept
reviewed
Dec 31, 2016
| output.forEach(data => process.stdout.write(data)); | ||
| process.exit(code); | ||
| console.error('Failed to locate lintable Electron application'.red); | ||
| if (global._resolveError) global._resolveError(); |
There was a problem hiding this comment.
I take it that this PR doesn't allow us to remove this kind of code?
There was a problem hiding this comment.
Hm, actually we might be able to
… rejection handler ISSUES CLOSED: #38
MarshallOfSound
force-pushed
the
ora4
branch
from
52d3643
to
f654f18
Compare
malept
approved these changes
Dec 31, 2016
dsanders11
pushed a commit
that referenced
this pull request
Jan 14, 2023
feat: Remember last selected version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #38
This looks quite large, but it is actually just indenting 😆