Skip to content
This repository has been archived by the owner on Mar 4, 2020. It is now read-only.

Assess variables to emit in generated config.gypi #71

Open
codebytere opened this issue Sep 28, 2018 · 3 comments
Open

Assess variables to emit in generated config.gypi #71

codebytere opened this issue Sep 28, 2018 · 3 comments

Comments

@codebytere
Copy link
Member

Assess which if any of the config variables are important to include in the js2c'd config.gypi generated by tools/generate_config_gypi.py.

/cc @nornagon

@hashseed
Copy link
Contributor

hashseed commented Feb 2, 2019

I implemented a way to generate config.gypi using a Jinja2 template here to fix Node.js tests failures.

@nornagon
Copy link
Member

nornagon commented Feb 4, 2019

Hm, jinja2 is an odd choice. config.gypi is just a python data structure, so repr() should be sufficient, no?

@hashseed
Copy link
Contributor

hashseed commented Feb 4, 2019

I'm not a python guy. I just took it because we have it in DEPS anyways. I found replacing stuff in a template easier to read than programmatically altering an object like Node.js' configure script does.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants