Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prune electron-nightly even if in dependencies #1538

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

erickzhao
Copy link
Member

@erickzhao erickzhao commented Jul 28, 2023

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

If electron-nightly is installed in dependencies by accident, we want to prune it.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1538 (7f4c194) into main (5ee6d73) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1538   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files          15       15           
  Lines         793      793           
=======================================
  Hits          758      758           
  Misses         35       35           
Files Changed Coverage Δ
src/prune.js 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erickzhao erickzhao marked this pull request as ready for review July 28, 2023 22:28
@erickzhao erickzhao requested a review from a team as a code owner July 28, 2023 22:28
@erickzhao erickzhao merged commit 741f3c3 into main Jul 31, 2023
11 checks passed
@erickzhao erickzhao deleted the erickzhao-patch-1 branch July 31, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants