Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiline absolute urls for nupkg #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zorn-v
Copy link

@zorn-v zorn-v commented May 26, 2023

Currently squirrel updates seems not working at all.
For example url https://update.electronjs.org/zorn-v/shareon-local-app/win32-x64/1.0.0/RELEASES returns

5417D2238661918281F026FFEC8E74821549646E https:/zorn-v/shareon-local-app/releases/download/v1.0.1/shareon_local_app-1.0.0-full.nupkg 98510713
C2F97B323A29A6FE36DA9633D2832BDBB6310CA5 shareon_local_app-1.0.1-delta.nupkg 70277894
07F3EFA74A2B8768C816B15182994C64DB340EB2 shareon_local_app-1.0.1-full.nupkg 98510705

But squirrel want to download 1.0.1 version.
And we get something like this in Squirrel-Update.log

[26.05.23 14:11:13] info: FileDownloader: Downloading url: https://update.electronjs.org/zorn-v/shareon-local-app/win32-x64/1.0.0/RELEASES?id=shareon_local_app&localVersion=1.0.0&arch=amd64
[26.05.23 14:11:14] info: FileDownloader: Downloading file: https://update.electronjs.org/zorn-v/shareon-local-app/win32-x64/1.0.0/shareon_local_app-1.0.1-delta.nupkg
[26.05.23 14:11:14] error: DownloadReleasesImpl: File Length should be 70277894, is 141

because https://update.electronjs.org/zorn-v/shareon-local-app/win32-x64/1.0.0/shareon_local_app-1.0.1-delta.nupkg is just json but not actual file

@zorn-v zorn-v requested a review from a team as a code owner May 26, 2023 13:15
@erickzhao erickzhao changed the title Multiline absolute urls for nupkg fix: multiline absolute urls for nupkg May 26, 2023
@zorn-v
Copy link
Author

zorn-v commented May 27, 2023

It applicable for releases with delta nupkg (e.g. with remoteReleases for @electron-forge/maker-squirrel).
Without it all works fine as there is only one nupkg in RELEASES file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant