Silent failure on misspelled options

[inimino]

I hesitate to admit how many hours this cost me...

How quickly can you spot the problem here?

emailjs.server.connect(
  {"username":"<redacted>"
  ,"password":"<redacted>"
  ,"tls":true
  ,"host":"<redacted>"
  ,"port":587
  });

Finally after sifting through log files on my mail server I found that the SMTP authentication just isn't happening at all. The "username" option does not exist, it should be "user".

So, my strong suggestion would be to whitelist the options and throw an exception if there are any unrecognized properties on the options object.

Would be happy to submit a PR for this...

[eleith]

that is a great UX suggestion. pull requests are welcome.

[maotora]

I also never got any emails until I understood my mixed options.

Please, some error/failure message will be helpful.

[zackschuster]

as of 2ce27a2 the constructor will error if it receives a password but no user. closing this as i think that resolves things, but feel free to re-open if you have any concerns :)