Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smtp.js:594 this.sock.write(data); Cannot read property 'write' of null at SMTP.message #245

Closed
amark opened this issue Feb 12, 2020 · 2 comments

Comments

@amark
Copy link

amark commented Feb 12, 2020

Probably related to #205 .

/app/node_modules/emailjs/smtp/smtp.js:594
this.sock.write(data);
TypeError: Cannot read property 'write' of null
at SMTP.message (/app/node_modules/emailjs/smtp/smtp.js:594:13)

Seems like writable socket this.sock is not being checked for ready state changes.

I might fork an ugly check to prevent crash, if others need/want or if this package still open to PRs/publishing. Tho, I was using this for sending debugging/crash reports (meta!) so I should probably switch to something less hacky than email.

@zackschuster
Copy link
Collaborator

the null reference exception was addressed as part of this commit. the fix will go out in the next release.

thank you! :)

@zackschuster
Copy link
Collaborator

@amark this is now live in 3.0.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants