Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement rfc2047 (mime word encoding) #247

Closed
zackschuster opened this issue May 27, 2020 · 2 comments · Fixed by #256
Closed

implement rfc2047 (mime word encoding) #247

zackschuster opened this issue May 27, 2020 · 2 comments · Fixed by #256

Comments

@zackschuster
Copy link
Collaborator

emailjs-mime-codec is no longer maintained. i'd like to replace it with a custom implementation like we did for momentjs. potentially this could shrink the bundle by quite a lot.

given how large a task this would be, i don't intend to start until after we ship v3.

rfc
@zackschuster
Copy link
Collaborator Author

experimenting with inlining code from emailjs-mime-codec & replacing calls to text-encoder with the built-in util replacements

before: 16,160 loc
after: 2,152 loc

promising!

@eleith
Copy link
Owner

eleith commented Jun 10, 2020

nice!

@zackschuster zackschuster mentioned this issue Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

smtp/mime: import code & tests from emailjs-mime-codec eleith/emailjs
2 participants
@eleith @zackschuster