ensure timeout is set to default value (fixes #225) #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleith
reviewed
Jul 6, 2018
| @@ -51,6 +51,10 @@ class SMTP extends EventEmitter { | |||
| constructor(options = {}) { | |||
| super(); | |||
|
|
|||
| if (options.timeout == null) { | |||
There was a problem hiding this comment.
i guess the way to think about this is that if timeout is not a number, then we default to TIMEOUT.
we could try to improve on default values using destructuring: https://wesbos.com/destructuring-default-values/ and then checking for proper types afterwards.
i'll merge this for now, but something to keep in mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.