Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converge on Explore rooms view for Spaces #5658

Closed
Tracked by #164
kittykat opened this issue Mar 29, 2022 · 4 comments · Fixed by #5834
Closed
Tracked by #164

Converge on Explore rooms view for Spaces #5658

kittykat opened this issue Mar 29, 2022 · 4 comments · Fixed by #5834
Assignees
Labels
A-Spaces Spaces, groups, communities

Comments

@kittykat
Copy link
Contributor

kittykat commented Mar 29, 2022

I took a look at the original designs and couldn't see any of the Android content at the top of explore, so in Figma they were always more similar to start with.

Explore space_ iOS@2x

Explore space_ And@2x

Small notes:

  • After recent discussions, its not clear what to do with subspaces, so just leave as they are on each platform for now
  • Please on Android, if there's no description/topic for a room, can the - not be visible (see below)? It should also be a middle dot, not a dash.

image

Figma Android

@kittykat kittykat transferred this issue from element-hq/element-meta Mar 29, 2022
@kittykat kittykat added the A-Spaces Spaces, groups, communities label Mar 29, 2022
@fedrunov
Copy link
Contributor

After discussion with @niquewoodhouse and @kittykat it was decided to keep list item (room) design unchanged, since same layout is used for suggested room item in room list. Also search probably should be a part of toolbar to align with other screens with rooms filtering.

New designs needed so reassign to @niquewoodhouse

@fedrunov fedrunov added the X-Needs-Design May require input from the design team label Apr 19, 2022
@niquewoodhouse
Copy link

Thanks @fedrunov for notes above.

Here's some designs with toolbar aligned with other screens, for more consistent experiences.

  1. Amended header to be like tabs, with filter on the right as an icon

This would be consistent with the more prominent lists of rooms in the app, so people should know how to use it but it would mean finding the search is slightly harder.

ele-android-explore-space-01.mov
  1. Add search like on explore public rooms

Room directory@2x

This would be my preference but I don't feel super strongly, @fedrunov could you comment on which is easier to do/more feasible please? Thanks

@fedrunov
Copy link
Contributor

fedrunov commented Apr 21, 2022

1st shouldn't be much harder to implement, and I also like it more than 2nd, so I vote for option 1

@niquewoodhouse
Copy link

1st shouldn't be much harder to implement, and I also like it more than 2nd, so I vote for option 1

I don't feel super strongly either way - happy to go with 1

@niquewoodhouse niquewoodhouse removed their assignment Apr 21, 2022
@niquewoodhouse niquewoodhouse removed the X-Needs-Design May require input from the design team label Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants