Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No ring or notification for incoming Jitsi group call #7761

Open
rajil opened this issue Dec 10, 2022 · 11 comments · May be fixed by #8893
Open

No ring or notification for incoming Jitsi group call #7761

rajil opened this issue Dec 10, 2022 · 11 comments · May be fixed by #8893
Labels
A-Jitsi O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@rajil
Copy link

rajil commented Dec 10, 2022

Steps to reproduce

Start a Jitsi group call in a room.

Outcome

What did you expect?

The room participants should have their phone ringing.

What happened instead?

Room participants (Android Element) do not get a notification and mobile phones do not ring.

Your phone model

No response

Operating system version

No response

Application version and app store

Element 1.5.8 (Google Play)

Homeserver

Synapse 1.73.0+focal1

Will you send logs?

No

Are you willing to provide a PR?

No

@rajil rajil added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Dec 10, 2022
@rajil rajil changed the title No ringing on incoming Jitsi group call No incoming ring or notification for incoming Jitsi group call Dec 10, 2022
@rajil rajil changed the title No incoming ring or notification for incoming Jitsi group call No ring or notification for incoming Jitsi group call Dec 10, 2022
@mnaturel mnaturel added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Occasional Affects or can be seen by some users regularly or most users rarely A-Jitsi labels Dec 12, 2022
@alexander-potemkin
Copy link

That is implemented on iOS version of the client. Could this help in bringing this feature to Android as well? Please! 🙏🏻

Captura 2024-03-22 a las 18 10 43 jpeg

@alexander-potemkin
Copy link

@mnaturel , I'm not sure if you are a right person to tag, please, correct me if that's not the case.

Is there something could be done to have this on Android as well?

@mnaturel
Copy link
Contributor

mnaturel commented Apr 5, 2024

@mnaturel , I'm not sure if you are a right person to tag, please, correct me if that's not the case.

Is there something could be done to have this on Android as well?

Hi @alexander-potemkin, unfortunately I am no longer part of the team but I will let @bmarty answer to this question. In most cases and if possible, I guess anyone can submit code changes to improve the app.

@alexander-potemkin
Copy link

@mnaturel , I'm not sure if you are a right person to tag, please, correct me if that's not the case.
Is there something could be done to have this on Android as well?

Hi @alexander-potemkin, unfortunately I am no longer part of the team but I will let @bmarty answer to this question. In most cases and if possible, I guess anyone can submit code changes to improve the app.

Oh, yeah, I'm sorry to hear that and thanks for stepping in anyway!

@bmarty , I understand that anyone can contribute, I'm wonder if you can help with some guidance on how you would like to see things done, to make sure it's done promptly and accepted by the team.

@alexander-potemkin
Copy link

@mnaturel , I'm sorry to bother you, especially given that you are no longer part of the team!
I guess @bmarty is not in a position to assist here, probably you aware of someone else who can help here?

@mnaturel
Copy link
Contributor

@mnaturel , I'm sorry to bother you, especially given that you are no longer part of the team! I guess @bmarty is not in a position to assist here, probably you aware of someone else who can help here?

Hello! Perhaps @ganfra or @BillCarsonFr could give you a reply on that?

@manuroe
Copy link
Member

manuroe commented Apr 19, 2024

Is there something could be done to have this on Android as well?

@alexander-potemkin. Everything is possible with software but the Element core team is actively working on Element X Android, not this project anymore. PR are welcome.

This is not useful to ping individuals, already busy on their tasks.

@alexander-potemkin
Copy link

@alexander-potemkin. Everything is possible with software but the Element core team is actively working on Element X Android, not this project anymore. PR are welcome.

This is not useful to ping individuals, already busy on their tasks.

@manuroe , I'm aware about Element-X, but it seems like not on par with current Element functionality and it will take some time to get up to speed.
I understand that everyone has something to do and I didn't mean it's not that. Being interested in that feature, I tried to get some responce and/or guidings or a rejection, to make sure I understand things correctly.
I hope @mnaturel help wasn't anything off the limits - from my perspective, it was an enormous help in navigating in the team structure I'm completely unaware off.

The reason I'm asking is exactly to make sure that the dedicate resources won't be wasted and PR would be accepted.

Could you please, let me know if there is anything to be considered, apart from Contributing rules, to make sure the group calls functionality will be accepted and merged promptly? Probably, some insider perspective, if that's not too much to ask?

Thank you in advance in any way!

@msulmanzig
Copy link

@alexander-potemkin am also working on this feature but unable to find the settings to enable this group call feature. If you find something kindly let me know.

@alexander-potemkin
Copy link

@alexander-potemkin am also working on this feature but unable to find the settings to enable this group call feature. If you find something kindly let me know.

This feature is not implemented by Android team, it only exists on iOS version.

Development is required and the team is mainly focused on Element-X now, so a that version is outside of the scope of they attention.

I'm trying to figure out the requirements to implement it (and have it merged!), but didn't get much so far, unfortunately.

Turubaev pushed a commit to NoCloud-today/element-android-with-group-calls that referenced this issue Sep 1, 2024
Turubaev pushed a commit to NoCloud-today/element-android-with-group-calls that referenced this issue Sep 1, 2024
Turubaev pushed a commit to NoCloud-today/element-android-with-group-calls that referenced this issue Sep 1, 2024
Turubaev pushed a commit to NoCloud-today/element-android-with-group-calls that referenced this issue Sep 1, 2024
Turubaev pushed a commit to NoCloud-today/element-android-with-group-calls that referenced this issue Sep 1, 2024
Turubaev pushed a commit to NoCloud-today/element-android-with-group-calls that referenced this issue Sep 2, 2024
Turubaev pushed a commit to NoCloud-today/element-android-with-group-calls that referenced this issue Sep 2, 2024
@Turubaev Turubaev linked a pull request Sep 2, 2024 that will close this issue
15 tasks
Turubaev pushed a commit to NoCloud-today/element-android-with-group-calls that referenced this issue Sep 2, 2024
@alexander-potemkin
Copy link

@manuroe , I understand that Element 'Classic' (not X) is not in focus now, but is there any chances you could review and ideally approve pull request from Timur (mentioned above)?

I understand it's a long desired feature and I would be glad to see it Element Android, alongside Element iOS.

Shall anything be required - please, let us (myself or @Turubaev) know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Jitsi O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants